Merge e2c455213c into 8d94c6ec1a

Add test to verify that a plugin can run dispatch to handle subtasks of
external plugins.

.github/workflows/ci.yml

@@ -47,11 +47,14 @@ jobs:
         run: |
           python -m tox
           python -m tox -e coverage_report
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v5
+        with:
+          fail_ci_if_error: true
+          token: ${{ secrets.CODECOV_TOKEN }}
   fmt:
     name: Format
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: psf/black@stable
       - uses: isort/isort-action@v1

codecov.yml

@@ -0,0 +1,4 @@
+coverage:
+  status:
+    project: off
+    patch: off

dotbot/dispatcher.py

@@ -18,7 +18,10 @@ class Dispatcher:
     ):
         self._log = Messenger()
         self._setup_context(base_directory, options)
-        plugins = plugins or []
+        if plugins == None:
+            plugins = Plugin.__subclasses__()
+        else:
+            plugins = plugins or []
         self._plugins = [plugin(self._context) for plugin in plugins]
         self._only = only
         self._skip = skip

tests/dotbot_plugin_dispatch.py

@@ -0,0 +1,17 @@
+"""Test that a plugin can call dispatcher for subtasks.
+
+The plugin calls dispatch with his data.
+"""
+
+import os.path
+
+import dotbot
+
+
+class Dispatch(dotbot.Plugin):
+    def can_handle(self, directive):
+        return directive == "dispatch"
+
+    def handle(self, directive, data):
+        dispatcher = dotbot.dispatcher.Dispatcher(self._context.base_directory())
+        return dispatcher.dispatch(data)

tests/test_dispatcher.py

@@ -0,0 +1,22 @@
+import os
+import shutil
+
+import pytest
+
+
+def test_plugin_dispatcher(capfd, home, dotfiles, run_dotbot):
+    """Verify that plugins can call dispatcher without explicitly specifying plugins."""
+
+    dotfiles.makedirs("plugins")
+    plugin_file = os.path.join(
+        os.path.dirname(os.path.abspath(__file__)), "dotbot_plugin_dispatch.py"
+    )
+    shutil.copy(plugin_file, os.path.join(dotfiles.directory, "plugins", "dispatch.py"))
+    dotfiles.write_config(
+        [
+            {"dispatch": [{"create": ["~/a"]}]},
+        ]
+    )
+    run_dotbot("--plugin-dir", os.path.join(dotfiles.directory, "plugins"))
+
+    assert os.path.exists(os.path.join(home, "a"))