psi-jack/dotbot
1
0
Fork 0
mirror of synced 2024-12-21 13:41:07 -05:00
Code Issues Releases Wiki Activity

Fix incorrect use of is over ==

Browse source 
Comparing strings and integers with `is` is a bug: comparisons should be
done with `==`. It might not have caused observable problems in the past
because small integers and strings can be interned.
This commit is contained in:
Anish Athalye 2020-01-03 14:42:45 -05:00
parent a7ed166817
commit 1e1885c45a
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
dotbot/plugins/link.py
View file

@ -51,19 +51,19 @@ class Link(dotbot.Plugin):
if use_glob: if use_glob:
self._log.debug("Globbing with path: " + str(path)) self._log.debug("Globbing with path: " + str(path))
glob_results = glob.glob(path) glob_results = glob.glob(path)
if len(glob_results) is 0: if len(glob_results) == 0:
self._log.warning("Globbing couldn't find anything matching " + str(path)) self._log.warning("Globbing couldn't find anything matching " + str(path))
success = False success = False
continue continue
glob_star_loc = path.find('*') glob_star_loc = path.find('*')
if glob_star_loc is -1 and destination[-1] is '/': if glob_star_loc == -1 and destination[-1] == '/':
self._log.error("Ambiguous action requested.") self._log.error("Ambiguous action requested.")
self._log.error("No wildcard in glob, directory use undefined: " + self._log.error("No wildcard in glob, directory use undefined: " +
destination + " -> " + str(glob_results)) destination + " -> " + str(glob_results))
self._log.warning("Did you want to link the directory or into it?") self._log.warning("Did you want to link the directory or into it?")
success = False success = False
continue continue
elif glob_star_loc is -1 and len(glob_results) is 1: elif glob_star_loc == -1 and len(glob_results) == 1:
# perform a normal link operation # perform a normal link operation
if create: if create:
success &= self._create(destination) success &= self._create(destination)