1
0
Fork 0
mirror of synced 2024-11-03 00:58:58 -04:00
Commit graph

45 commits

Author SHA1 Message Date
Javier Bértoli
7ee2569b45 fix(config): remove dictsort that breaks sudoers
in bc62b6e5 dictsort was applied to the pillar entries. But in the
sudoers file *order matters* so, using `dictsort`, breaks it.

From man 5 sudoers:

> When multiple entries match for a user, they are
> applied in order.  Where there are multiple matches, the last match
> is used (which is not necessarily the most specific match).

Removed `dictsort` from the {users,groups,netgroups} specifications.

BREAKING CHANGE: sudoers entries' order will change and might break
existing configuration. You should check your pillars and rendering.
2020-08-24 19:46:55 -03:00
Andre Sencioles
b925a00048 Fix issue #25
Add "makedirs: True" to the included.sls file as suggested by @tjuup
2018-11-07 10:18:05 +13:00
Niels Abspoel
2fa535ec3a
Merge pull request #43 from ze42/dictsort
dictsort: ensure the dict order is stable
2018-10-27 23:43:45 +02:00
Sebastian Meyer
73d2d70dbb
Make management of the main sudoers config optional
It should be possible to not overwrite the main sudoers configuration
file and only provide files to be included. This introduces a new Pillar
variable to achieve that. If it's not set we default to the old
behaviour of managing that file.
2018-08-22 12:30:32 +02:00
9numbernine9
d5d68ea963 Add support for netgroups 2018-08-14 13:29:49 +01:00
Adrien "ze" Urban
bc62b6e567 dictsort: ensure the dict order is stable
Makes changes easier to read when adding/removing an entry.
Other lines will not be reordered because of unrelated stuffs.
2018-06-25 11:29:28 +02:00
Jessy
e4501d10d3 added includedir as variable (mostly for FreeBSD)
include files can now be specified with the filename only.
2018-02-04 20:04:11 +01:00
Alejandro Bednarik
ae1b5dab1b Update include.sls with correct execprefix reference
Sorry Imissed this update
2017-08-16 11:52:38 -03:00
abednarik
24e66ca8bf Remove dashes from variables.
Dashes causes some weird issues while rendering jinja templates.
2017-08-16 09:32:42 -03:00
Matthew X. Economou
672cd20672 Use correct pathname of visudo on FreeBSD 2016-03-09 15:03:56 -05:00
Roman Reitschmied
8d3f4d9894 add sudoers check with visudo as proposed here: https://blog.afoolishmanifesto.com/posts/checking-sudoers-with-visudo-in-saltstack/ 2016-02-11 15:00:22 +01:00
Niels Abspoel
052923a076 added opensuse support 2015-03-07 11:28:49 +01:00
Simon Lloyd
34f3aed102 Fix overwriting dictionary with pillar data.
The dictionary ``sudoers`` is defined twice instead of once,
and then updated with additional values from pillar data. This
prevents looking up map values. This patch updates, instead of
overwrites the dictionary.
2015-01-10 23:48:19 +01:00
Robert Fairburn
3db683d657 Fixes escaped spaces in users/groups 2015-01-09 09:14:09 -06:00
Niels Abspoel
c2265a81f6 Added archlinux support and improved lookup table 2015-01-01 23:44:47 +01:00
Niels Abspoel
78b8323716 updated pillar lookup with map.jinja 2015-01-01 23:14:56 +01:00
Simon Lloyd
ffc287bf34 included_files default changed to empty dict. 2014-12-24 15:08:03 +01:00
ymage
e732663da9 Revert change
The '#' here does not indicate a comment
2014-12-12 14:57:35 +01:00
ymage
f9e8655284 Update sudoers
Enable includedir
2014-12-11 14:45:57 +01:00
Jason Wolfe
5f6395fc43 FreeBSD support with group 0 being wheel, clean up config-path 2014-10-13 23:15:30 -07:00
Kevin Bowling
8fa0d85ac9 Initial FreeBSD support 2014-10-02 00:29:40 -07:00
Andrew Vant
c9230f1b14 Added Linux Mint support. 2014-10-01 11:26:17 -04:00
Andrew Vant
8bf6d6711f Fixed default permissions for Debian-based distributions.
The code around lines 84 and 91 expects 'specs' to be a list,
but the defaults provide a single string value. This causes
wrong behavior if sudoers:users or sudoers:groups are not
specified in pillar.
2014-10-01 11:03:54 -04:00
Robert Fairburn
cd1ddcf25f allow for multiple lines for the same user or group 2014-08-19 09:26:47 -05:00
Reuven V. Gonzales
3744718f8c Correctly set variables for template 2014-07-30 02:10:50 -07:00
Robert Fairburn
fb3773a605 switch default from list to dict on include to match the global configuration 2014-07-09 13:36:47 -05:00
Robert Fairburn
1c3e6844bc Fix broken logic surrounding includes and Debian defaults 2014-07-09 13:35:07 -05:00
Robert Fairburn
7662f1272e attempt to resolve error processing files missing defaults 2014-07-09 13:26:26 -05:00
Robert Fairburn
6941d548fb Add support for Amazon Linux 2014-07-09 13:04:26 -05:00
Robert Fairburn
595f90c5d4 fix typo in the sudoers file that was causing the wrong data to get populated under new fields 2014-07-09 12:56:16 -05:00
Robert Fairburn
ac278d226c Extend defaults section of sudoers to permit the following:
Default_Type ::= 'Defaults' |
                 'Defaults' '@' Host_List |
                 'Defaults' ':' User_List |
                 'Defaults' '!' Cmnd_List |
                 'Defaults' '>' Runas_List
2014-07-09 12:21:58 -05:00
Carlos Perelló Marín
642a93d7df Improved default values for Debian based distributions to match the distribution default values 2014-02-09 18:34:27 +01:00
Carlos Perelló Marín
461107d8db Added sudoers.included formula to manage included sudoers files 2014-02-09 18:32:22 +01:00
Evan Borgstrom
ba9c94ce91 Add missing hash on custom includedir 2013-11-16 08:21:53 -05:00
Kenneth Wilke
7f4a0d6834 more newline removal 2013-08-20 16:55:49 -05:00
Kenneth Wilke
1c652bdffe more newline removal 2013-08-20 16:55:11 -05:00
Kenneth Wilke
7100b0ed13 small newline removal 2013-08-20 16:54:54 -05:00
Kenneth Wilke
3db435dcdd template cleanup 2013-08-20 16:54:21 -05:00
Kenneth Wilke
7ae89c11ec user/group fix 2013-08-20 16:53:00 -05:00
Kenneth Wilke
61a216de81 fleshed out template 2013-08-20 16:51:13 -05:00
Kenneth Wilke
34178002e7 alias test 2013-08-20 16:45:11 -05:00
Kenneth Wilke
4f842bf457 includedir fix 2013-08-20 16:35:57 -05:00
Kenneth Wilke
ffda08bc09 init.sls fix 2013-08-20 16:35:12 -05:00
Kenneth Wilke
be815275bb fixed pkgs variable 2013-08-20 16:34:35 -05:00
Kenneth Wilke
8eb95cfcda start of sudoers formula 2013-08-20 16:32:58 -05:00