Linux-Help/dynamic-ip
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Finally fixed bugs and shellcheck cleanup

Browse source
This commit is contained in:
Eric Renfro 2023-10-31 14:32:14 -04:00
parent a28ee9e34c
commit b2baa656b9
Signed by: psi-jack
GPG key ID: 14977F3A50D9A5BF
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/agents.d/update-dns-namecheap
View file

@ -44,9 +44,8 @@ _update_dns_namecheap() {
local result local result
local errors local errors
result="$(curl -qs \"https://dynamicdns.park-your-domain.com/update?host=${dnsHostname}&domain=${dnsDomain}&password=${dnsToken}&ip=${dnsIP}" | grep ErrCount)" if result=$(curl -qs "https://dynamicdns.park-your-domain.com/update?host=${dnsHostname}&domain=${dnsDomain}&password=${dnsToken}&ip=${dnsIP}" | grep ErrCount); then
if [[ $? -eq 0 ]]; then errors=$(grep -oPm1 "(?<=<ErrCount>)[^<]+" <<< "$result")
errors="$(grep -oPm1 "(?<=<ErrCount>)[^<]+" <<< $result)"
if [[ "$errors" -eq 0 ]]; then if [[ "$errors" -eq 0 ]]; then
echo "DNS record ${dnsHostname}.${dnsDomain} updated successfully." echo "DNS record ${dnsHostname}.${dnsDomain} updated successfully."
@ -68,11 +67,11 @@ _get_host_and_domain "$DIP_RECORD" || return 99
if valid_ipv4 "$DIP_CUR_IP"; then if valid_ipv4 "$DIP_CUR_IP"; then
log "Updating Namecheap DNS IPv4 Record for ${hostname}.${domain}" log "Updating Namecheap DNS IPv4 Record for ${hostname}.${domain}"
_update_dns_namecheap "$hostname" "$domain" "$token" "${DIP_CUR_IP}" _update_dns_namecheap "$hostname" "$domain" "$token" "${DIP_CUR_IP}"
return $? exit $?
fi fi
if valid_ipv6 "$DIP_CUR_IP"; then if valid_ipv6 "$DIP_CUR_IP"; then
log "Updating Namecheap DNS IPv6 Record for ${hostname}.${domain}" log "Updating Namecheap DNS IPv6 Record for ${hostname}.${domain}"
_update_dns_namecheap "$hostname" "$domain" "$token" "${DIP_CUR_IP}" _update_dns_namecheap "$hostname" "$domain" "$token" "${DIP_CUR_IP}"
return $? exit $?
fi fi