From 7add8662157438b9a18b1eead0357b7857049085 Mon Sep 17 00:00:00 2001 From: Bao Trinh Date: Sat, 17 Nov 2018 15:00:18 -0600 Subject: [PATCH 1/2] Support defining default conditional option for links --- dotbot/plugins/link.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dotbot/plugins/link.py b/dotbot/plugins/link.py index bf1c5a9..2506237 100644 --- a/dotbot/plugins/link.py +++ b/dotbot/plugins/link.py @@ -30,12 +30,10 @@ class Link(dotbot.Plugin): relink = defaults.get('relink', False) create = defaults.get('create', False) use_glob = defaults.get('glob', False) + test = defaults.get('if', None) if isinstance(source, dict): # extended config - test = source.get('if') - if test is not None and not self._test_success(test): - self._log.lowinfo('Skipping %s' % destination) - continue + test = source.get('if', test) relative = source.get('relative', relative) force = source.get('force', force) relink = source.get('relink', relink) @@ -44,6 +42,9 @@ class Link(dotbot.Plugin): path = self._default_source(destination, source.get('path')) else: path = self._default_source(destination, source) + if test is not None and not self._test_success(test): + self._log.lowinfo('Skipping %s' % destination) + continue path = os.path.expandvars(os.path.expanduser(path)) if use_glob: self._log.debug("Globbing with path: " + str(path)) From 1be9f7532b535675f1e79f4eb96adf45a0de811b Mon Sep 17 00:00:00 2001 From: Anish Athalye Date: Mon, 19 Nov 2018 20:38:29 -0500 Subject: [PATCH 2/2] Add test --- test/tests/link-if.bash | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/test/tests/link-if.bash b/test/tests/link-if.bash index 9fe6429..1ea7709 100644 --- a/test/tests/link-if.bash +++ b/test/tests/link-if.bash @@ -30,3 +30,22 @@ grep "apple" ~/.f && grep "apple" ~/.h && ! test -f ~/.i ' + +test_expect_success 'run 2' ' +run_dotbot <