From 0098c5261036c7299150c75ef3c2d852a127e44a Mon Sep 17 00:00:00 2001
From: Dave Steinberg <dave@steinberg.dev>
Date: Sun, 19 Jul 2020 20:52:39 -0400
Subject: [PATCH] Support named, conditional tasks.

A new property called task can be used to assign a name. If it is
specified, then the task's actions must be nested under an actions
property, and an if property can be used to make it conditional.
Just like on a link action, the value is executed in the shell. If
it has a non-zero exit code (failure), the whole task is skipped.
This allows tasks to group actions that only apply in certain
conditions (e.g. on certain OSes or in certain configurations),
and allows all actions (not just link) to be conditional.

If there is no task property, then the task behaves exactly as
it did previously.
---
 dotbot/dispatcher.py | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/dotbot/dispatcher.py b/dotbot/dispatcher.py
index f945d54..2d3b25f 100644
--- a/dotbot/dispatcher.py
+++ b/dotbot/dispatcher.py
@@ -22,35 +22,43 @@ class Dispatcher(object):
     def dispatch(self, tasks):
         success = True
         for task in tasks:
-            test = task.get('if', None)
-            if test is not None and not test_success(test, cwd=self._context.base_directory(), log=self._log):
-                self._log.lowinfo('Skipping task')
-                continue
-            for action in task:
-                if action == 'if':
-                    continue
+            actions = task
+            name = task.get('task', None)
+            if name is not None:
+                test = task.get('if', None)
+                if test is not None and not test_success(test, cwd=self._context.base_directory(), log=self._log):
+                    self._log.info('Skipping task %s' % name)
+                    actions = []
+                else:
+                    actions = task.get('actions', [])
+                    if not actions:
+                        self._log.info('Task %s has no actions' % name)
+                    else:
+                        self._log.info('Starting task %s' % name)
+            for action in actions:
                 if self._only is not None and action not in self._only \
                         or self._skip is not None and action in self._skip:
                     self._log.info('Skipping action %s' % action)
                     continue
                 handled = False
                 if action == 'defaults':
-                    self._context.set_defaults(task[action]) # replace, not update
+                    self._context.set_defaults(actions[action]) # replace, not update
                     handled = True
                     # keep going, let other plugins handle this if they want
                 for plugin in self._plugins:
                     if plugin.can_handle(action):
                         try:
-                            success &= plugin.handle(action, task[action])
+                            success &= plugin.handle(action, actions[action])
                             handled = True
                         except Exception as err:
                             self._log.error(
                                 'An error was encountered while executing action %s' %
                                 action)
-                            self._log.debug(err)
                 if not handled:
                     success = False
                     self._log.error('Action %s not handled' % action)
+            if name and actions:
+                self._log.info('Task %s completed' % name)
         return success
 
     def _load_plugins(self):